Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the post uninstall survey on Windows (uplift to 1.32.x) #11370

Closed
wants to merge 1 commit into from

Conversation

bsclifton
Copy link
Member

Uplift of #10078
Fixes brave/brave-browser#18063

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 1.32.x - Release #4 milestone Dec 1, 2021
@bsclifton bsclifton requested a review from a team December 1, 2021 17:15
@bsclifton bsclifton self-assigned this Dec 1, 2021
@bsclifton bsclifton requested a review from a team as a code owner December 1, 2021 17:15
@bsclifton bsclifton removed the request for review from a team December 1, 2021 17:15
@kjozwiak
Copy link
Member

kjozwiak commented Dec 1, 2021

Closing after discussing with @rebron & @bsclifton. We're going to try keeping 1.32.x light as possible. We'll get this uplifted into 1.33.x via #11369.

@kjozwiak kjozwiak closed this Dec 1, 2021
@kjozwiak kjozwiak deleted the pr10078_bsc-uninstall-survey_1.32.x branch December 1, 2021 23:52
@kjozwiak kjozwiak removed the request for review from a team December 1, 2021 23:52
@kjozwiak kjozwiak removed this from the 1.32.x - Release #4 milestone Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants