Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed header to match design #11500

Conversation

muliswilliam
Copy link
Contributor

@muliswilliam muliswilliam commented Dec 8, 2021

Removed header info from the Add/Switch Network Panels to match what's in the figma design.

  • Removed Network top left
  • Removed Address top middle
  • Removed Account Orb top right

Resolves brave/brave-browser#19692

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screenshot 2021-12-08 at 18 37 20

@muliswilliam muliswilliam self-assigned this Dec 8, 2021
@muliswilliam muliswilliam marked this pull request as ready for review December 8, 2021 15:39
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@muliswilliam muliswilliam force-pushed the remove-header-from-add-and-switch-network-panels-to-match-design branch from bdde56d to 486ad01 Compare December 8, 2021 16:19
@muliswilliam muliswilliam merged commit f99d2b3 into master Dec 8, 2021
@muliswilliam muliswilliam deleted the remove-header-from-add-and-switch-network-panels-to-match-design branch December 8, 2021 16:38
@muliswilliam muliswilliam added this to the 1.35.x - Nightly milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Header Info From Add and Switch Network Panels
2 participants