Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy fix for wrong addresses #1173

Merged
merged 1 commit into from
Dec 22, 2018
Merged

Legacy fix for wrong addresses #1173

merged 1 commit into from
Dec 22, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Dec 21, 2018

Resolves brave/brave-browser#2172

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • create profile on master (previous version)
  • close browser
  • modify addressed in ledger_state
  • start browser
  • make sure that old addresses are still displayed
  • close browser
  • switch to this branch (current version)
  • start browser
  • make sure that addresses are correct now

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler jasonrsadler merged commit 48da074 into master Dec 22, 2018
@jasonrsadler jasonrsadler deleted the wrong-address branch December 22, 2018 20:50
jasonrsadler pushed a commit that referenced this pull request Dec 22, 2018
Legacy fix for wrong addresses
@jasonrsadler
Copy link
Contributor

master (0.61.x): 48da074
0.60.x: cae8381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix users who already restored wallets but UI displays incorrect addresses
3 participants