Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skipValidation flag for GetPriceQuote call (uplift to 1.34.x) #11913

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 20, 2022

Uplift of #11903
Resolves brave/brave-browser#20572

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 20, 2022 01:30
@brave-builds brave-builds requested a review from a team January 20, 2022 01:30
@brave-builds brave-builds self-assigned this Jan 20, 2022
@brave-builds brave-builds added this to the 1.34.x - Release #2 milestone Jan 20, 2022
@kjozwiak
Copy link
Member

Restarting Win due to an issue with the node as per https://ci.brave.com/job/pr-brave-browser-pr11903_skip_validation_flag_1.34.x-windows/1/execution/node/108/log/.

An error occurred (IncorrectInstanceState) when calling the StopInstances operation: This instance 'i-0598bff02c193979a' is not in a state from which it can be stopped.

Restarting macOS due to npm timing out as per https://ci.brave.com/job/pr-brave-browser-pr11903_skip_validation_flag_1.34.x-macos/1/execution/node/130/log/.

 Error: Timeout trying to fetch resolutions from npm

@kjozwiak
Copy link
Member

Restarting Linux due to the same issue that Win had re: issues with the instance/node as per https://ci.brave.com/job/pr-brave-browser-pr11903_skip_validation_flag_1.34.x-linux/1/execution/node/101/log.

01:35:04  An error occurred (InvalidInstanceID.NotFound) when calling the StopInstances operation: The instance ID 'i-07eb190178f19c528' does not exist

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.34.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #11903 (comment).

@kjozwiak kjozwiak merged commit e156f1a into 1.34.x Jan 20, 2022
@kjozwiak kjozwiak deleted the pr11903_skip_validation_flag_1.34.x branch January 20, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants