-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): Send Error Improvements with Tooltips #12327
Conversation
A Storybook has been deployed to preview UI for the latest push |
components/brave_wallet_ui/components/buy-send-swap/send/index.tsx
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/components/buy-send-swap/swap-input-component/index.tsx
Outdated
Show resolved
Hide resolved
d2627ac
to
8021594
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed the wording changes internally. Good to merge as-is. If the strings aren't getting too long, you can try these too:
Address did not pass verification (invalid checksum). Please try again, replacing lowercase letters with uppercase.
Address cannot be verified (missing checksum). Proceed?
8021594
to
c9c855c
Compare
A Storybook has been deployed to preview UI for the latest push |
Description
Send Error Improvements with Tooltips
Tooltip
to the send button that will only appear during 2 disabled states.0
tooltip will displayAmount must be greater than 0
empty
tooltip will displayTo address is required
warning
message toThis address cannot be verified. Proceed?
.error
message toAddress did not pass verification. Please try again, replacing lowercase letters with uppercase.
warning
anderror
messages now have aLearn more.
button that will link to the sameSupport Page
Resolves brave/brave-browser#21053
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Screen.Recording.2022-02-17.at.9.38.07.AM.mov