Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Send Error Improvements with Tooltips #12327

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

Send Error Improvements with Tooltips

  1. Added a Tooltip to the send button that will only appear during 2 disabled states.
  • Input amount is 0 tooltip will display Amount must be greater than 0
  • Address is empty tooltip will display To address is required
  1. Changed checksum warning message to This address cannot be verified. Proceed?.
  2. Changed checksum error message to Address did not pass verification. Please try again, replacing lowercase letters with uppercase.
  3. Both checksum warning and error messages now have a Learn more. button that will link to the same Support Page

Resolves brave/brave-browser#21053

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2022-02-17.at.9.38.07.AM.mov

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 18, 2022 01:54
@Douglashdaniel Douglashdaniel self-assigned this Feb 18, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 18, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed the wording changes internally. Good to merge as-is. If the strings aren't getting too long, you can try these too:

Address did not pass verification (invalid checksum). Please try again, replacing lowercase letters with uppercase.

Address cannot be verified (missing checksum). Proceed?

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Feb 23, 2022
@Douglashdaniel Douglashdaniel merged commit 689d3a2 into master Feb 23, 2022
@Douglashdaniel Douglashdaniel deleted the send-error-improvements branch February 23, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tooltip to Disabled Send Button State
5 participants