Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cr99 follow up] Fixes Bookmarks UI settings page styling. #12359

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#21227

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team as a code owner February 22, 2022 17:33
@mkarolin mkarolin self-assigned this Feb 22, 2022
@mkarolin
Copy link
Collaborator Author

Windows CI is failing on dist-delta, which is unrelated to this PR.

@mkarolin mkarolin merged commit 8c49a0f into master Feb 23, 2022
@mkarolin mkarolin deleted the maxk-cr99-fup-fix-bookmarks-styling branch February 23, 2022 16:15
@mkarolin mkarolin added this to the 1.37.x - Nightly milestone Feb 23, 2022
mkarolin added a commit that referenced this pull request Feb 23, 2022
[Cr99 follow up] Fixes Bookmarks UI settings page styling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmarks folder layout color and style is getting changed upon mouse hover
2 participants