Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Implemented Balance Updater Interval #12433

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

Implemented a Balance Updater Interval

  1. If a wallet is Created and Unlocked upon Initialized, beginUpdatingBalances will be called which will update balances every 15 seconds.
  2. If a wallet is locked it will call stopUpdatingBalances and stop the interval.
  3. Moved fetching visibleAssets out of refreshBalances and into its own new method refreshVisibleTokenInfo since it was causing undesirable state updates through out the wallet in places where userTokenInfo needs to be used as a dependency.
  4. Removed accounts as a dependency in the crypto view's useEffect hook because it was causing undesirable state updates on the Portfolio page every-time refreshBalances was called.

Resolves brave/brave-browser#21304

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Page Demo (Watch til end):

Screen.Recording.2022-02-28.at.11.52.41.AM.mov

Panel Demo (Watch til end):

Screen.Recording.2022-02-28.at.11.56.36.AM.mov

@Douglashdaniel Douglashdaniel self-assigned this Feb 28, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 28, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel added this to the 1.38.x - Nightly milestone Mar 1, 2022
@Douglashdaniel Douglashdaniel merged commit dcd49db into master Mar 1, 2022
@Douglashdaniel Douglashdaniel deleted the update-balances-interval branch March 1, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a Refresh Balances Interval
3 participants