-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): Backed Up Transactions Warning #12439
Conversation
components/brave_wallet_ui/components/extension/confirm-transaction-panel/index.tsx
Outdated
Show resolved
Hide resolved
A Storybook has been deployed to preview UI for the latest push |
d74e77e
to
a2f49f2
Compare
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a2f49f2
to
09e6c66
Compare
A Storybook has been deployed to preview UI for the latest push |
09e6c66
to
208fc96
Compare
A Storybook has been deployed to preview UI for the latest push |
Closing this PR as |
Description
Implemented a Backed Up Transactions Warning
In the case that user has submitted a transaction and the miners are not able to pick it up due to low submitted
gas
.This warning will show if a user attempts to create another transaction and the old
Submitted
one is over24
hours old.Clear and continue
we override the old transaction by setting thenonce
of the newUnapproved
transaction to thenonce
of the old stuckSubmitted
transaction.Clear and continue
we treat the newUnapproved
transaction as normal.Unapproved
transactions in queue, the first transactions will display the warning with theClear and continue
option. If chosen the nextUnapproved
transactions will show the same warning with out theClear and continue
option until the first transaction isConfirmed
on the blockchain.Resolves brave/brave-browser#21051
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:
Demo (note: For this demo I set it to show the warning after a
Submitted
transaction is 30 seconds old, will actually show if a transaction is still returned asSubmitted
after 24 hours.)Working.Example.mov