Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Brave news - disables default peeking card #12492

Merged
merged 1 commit into from
Mar 6, 2022
Merged

[Android] Brave news - disables default peeking card #12492

merged 1 commit into from
Mar 6, 2022

Conversation

alexsafe
Copy link
Contributor

@alexsafe alexsafe commented Mar 4, 2022 •
edited by kjozwiak
Loading

Uplift of #12489
Resolves brave/brave-browser#21477

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 4, 2022
@alexsafe alexsafe added this to the 1.37.x - Beta milestone Mar 4, 2022
@alexsafe alexsafe requested a review from a team March 4, 2022 21:35
@alexsafe alexsafe self-assigned this Mar 4, 2022
kjozwiak
kjozwiak approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.37.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #12489 (comment).

@kjozwiak kjozwiak merged commit b486d94 into 1.37.x Mar 6, 2022
@kjozwiak kjozwiak deleted the bravewnews-android-disables-default-optincard-1.37.x branch March 6, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@alexsafe alexsafe

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsafe @kjozwiak