Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Cargo download check more reliable 0.61.x #1312

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Make Cargo download check more reliable 0.61.x #1312

merged 1 commit into from
Jan 14, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 11, 2019

fix brave/brave-browser#2925

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@tmancey tmancey added the 0.61.x label Jan 11, 2019
@tmancey tmancey self-assigned this Jan 11, 2019
@tmancey tmancey changed the title Make Cargo download check more reliable Make Cargo download check more reliable 0.61.x Jan 11, 2019
@tmancey tmancey merged commit 1365633 into master Jan 14, 2019
@tmancey tmancey deleted the issues/2925-0.61.x branch January 14, 2019 09:30
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@tmancey tmancey

Labels
None yet
Projects
None yet
Milestone
0.61.x - Release
Development

Successfully merging this pull request may close these issues.

cargo download check isn't reliable
2 participants
@tmancey @bbondy