Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact form to show actual hostname (not display name) #13382

Merged
merged 1 commit into from
May 19, 2022

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented May 18, 2022

Fixes brave/brave-browser#22628

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue description brave/brave-browser#22628 for specific

  1. Enable flags for VPN (sku sdk, vpn, sku sdk env = dev)
  2. Login to account.brave.com and have VPN purchased
  3. Pick a server using VPN button and connect to it
  4. Click gear icon to contact support
  5. Verify that hostname shows up in the contact form

@bsclifton bsclifton self-assigned this May 18, 2022
@bsclifton bsclifton added this to the 1.41.x - Nightly milestone May 19, 2022
@bsclifton bsclifton merged commit 36778d3 into master May 19, 2022
@bsclifton bsclifton deleted the bsc-fix-vpn-contact-hostname branch May 19, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hostname field in submitted user-support data to Guardian lists city, rather than actual hostname
2 participants