Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top sites from NTP #13519

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented May 28, 2022

Resolves brave/brave-browser#23118

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 28, 2022
@deeppandya deeppandya added this to the 1.41.x - Nightly milestone May 28, 2022
@deeppandya deeppandya self-assigned this May 28, 2022
Copy link
Contributor

@wchen342 wchen342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya changed the title Remove brave stats and top sites from NTP Remove top sites from NTP Jun 2, 2022
@deeppandya deeppandya force-pushed the remove_stats_and_topsites_from_ntp branch from f925fe6 to bf41459 Compare June 2, 2022 17:53
@deeppandya deeppandya merged commit 3f74c99 into master Jun 2, 2022
@deeppandya deeppandya deleted the remove_stats_and_topsites_from_ntp branch June 2, 2022 22:34
brave-builds pushed a commit that referenced this pull request Jun 7, 2022
deeppandya pushed a commit that referenced this pull request Jun 9, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Jun 15, 2022

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.41.64 Chromium: 103.0.5060.42 (Official Build) canary (32-bit)
--- | ---
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS | Android 13; Build/TPB3.220513.017.B1

STR/Cases

  • ensured that the Top Tiles being displayed under NTP on a clean install (you'll need to open a second tab due known issue)
  • ensured that Show Top sites is enabled by default via Settings -> New Tab Page`
  • ensured that the Top Tiles is displayed under the NTP after several restarts
  • ensured that the Top Tiles are removed from NTP when disabled via Settings -> New Tab Page
  • ensured that Top Tiles isn't visible after opening several NTP after being disabled
  • ensured that Top Tiles isn't visible after restarting the browser several times after being disabled
  • ensured there's no obvious issues when going between portrait & horizontal modes while Top Tiles are disabled
  • ensured that Brave still remembers the most popular websites and still populates Top Tiles even though disabled
    • Example: Disable Top Tiles, visit several websites and than re-enable (they should be appearing via the Top Tiles
  • ensured that all the context menu's are working as expected after Disabling and than Enabling the Top Tiles
    • Open in new tab in group, Open in Private tab, Open in other window, Download link, Remove
  • ensured that Top Tilesare still visible/working when bothShow Background Images&Sponsored Images` are disabled
  • ensured that two rows are being displayed when both Show Background Images & Sponsored Images are disabled
  • ensured that Top Tiles can be disabled when both Show Background Images & Sponsored Images are disabled

Found brave/brave-browser#23474 while running through the above.

Upgrade Cases:

Upgrading from a version without the feature/toggle to the latest version with the above feature

  • downloaded/installed 1.41.34 Chromium: 102.0.5005.78
  • ensured that Show Top sites is not visible/available under Settings -> New Tab Page
  • Upgraded to 1.41.64 Chromium: 103.0.5060.42
  • ensured that Top Tiles are still visible under NTP
  • ensured that Show Top sites is enabled via Settings -> New Tab Page

Disabling Top Sites and then upgrading and ensuring the setting persists/retains

  • downloaded/installed 1.41.36 Chromium: 102.0.5005.78
  • disabled Show Top sites from Settings -> New Tab Page and restarted re-launched the browser as specified
  • Upgraded to 1.41.64 Chromium: 103.0.5060.42
  • ensured that Top Top tiles are not being displayed under NTP
  • ensured that Show Top sites is disabled via Settings -> New Tab Page
Example Example Example Example
Screenshot_20220615-004304 Screenshot_20220615-004103 Screenshot_20220615-012624 Screenshot_20220615-012613

@distbit0
Copy link

Thanks so much for this!! Epic. Now I will have significantly less opportunity to be distracted by recommended sites displayed in top sites 👍

Mick appreciated. @kjozwiak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an option to remove Top Tiles from NTP
4 participants