Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables Android DApps support by default #13547

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented May 31, 2022

Resolves brave/brave-browser#23159
Sec review link https://github.com/brave/security/issues/885

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Make sure that DApps support is enabled by default on Android

Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as security gives the OK.

@SergeyZhukovsky
Copy link
Member Author

That PR has nothing to do with iOS, tried to restart it few times, but it gets aborted. Merging.

@SergeyZhukovsky SergeyZhukovsky added this to the 1.41.x - Nightly milestone Jun 16, 2022
@SergeyZhukovsky SergeyZhukovsky merged commit ef3de15 into master Jun 16, 2022
@SergeyZhukovsky SergeyZhukovsky deleted the android_dapps_default branch June 16, 2022 02:39
brave-builds pushed a commit that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DApps: Enable DApps support by default
2 participants