Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex action support for debouncing (only on path) #13551

Merged
merged 8 commits into from
Jun 16, 2022

Conversation

ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul commented Jun 1, 2022

Resolves brave/brave-browser#23121
Security/privacy review: https://github.com/brave/security/issues/888

Related filter list update to debounce AMP cache URLs: brave/adblock-lists#940

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please see brave/brave-browser#23121 (comment)

@ShivanKaul ShivanKaul added this to the 1.41.x - Nightly milestone Jun 1, 2022
@ShivanKaul ShivanKaul requested a review from a team as a code owner June 1, 2022 02:40
@ShivanKaul ShivanKaul self-assigned this Jun 1, 2022
@iefremov
Copy link
Contributor

iefremov commented Jun 1, 2022

cc @atuchin-m as this is performance sensitive

@iefremov iefremov requested a review from atuchin-m June 1, 2022 13:15
@pes10k
Copy link
Contributor

pes10k commented Jun 1, 2022

cc @cuba just a heads up that the iOS debouncing work will need to be extended to handle these new kinds of rules too

@ShivanKaul ShivanKaul changed the title Regex action support for debouncing Regex action support for debouncing (only on path) Jun 2, 2022
components/debounce/browser/debounce_rule.h Outdated Show resolved Hide resolved
components/de_amp/common/pref_names.cc Outdated Show resolved Hide resolved
components/debounce/browser/debounce_rule.cc Show resolved Hide resolved
components/debounce/browser/debounce_rule.cc Outdated Show resolved Hide resolved
components/debounce/browser/debounce_rule.cc Outdated Show resolved Hide resolved
@ShivanKaul ShivanKaul requested review from atuchin-m and bridiver and removed request for a team, iefremov, simonhong and samartnik June 15, 2022 18:37
LOG(INFO) => VLOG(1)
Log as a warning only when issues reading/parsing rules file, everything else is a VLOG(1)
@ShivanKaul ShivanKaul merged commit 6d36df2 into master Jun 16, 2022
@ShivanKaul ShivanKaul deleted the feature/debounce/regex branch June 16, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to debounce URLs based on a regex applied to the path
7 participants