Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes logs #1371

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Removes logs #1371

merged 1 commit into from
Jan 17, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 17, 2019 •
edited
Loading

Resolves brave/brave-browser#3002

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • make sure that logs are not present anymore

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc added this to the 0.61.x - Nightly milestone Jan 17, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 17, 2019
@ryanml ryanml merged commit bc836d5 into master Jan 17, 2019
@ryanml ryanml deleted the refactor-db-cleanup branch January 17, 2019 08:19
NejcZdovc pushed a commit that referenced this pull request Jan 17, 2019
@ryanml @NejcZdovc
Merge pull request #1371 from brave/refactor-db-cleanup
8ad5980 
Removes logs
@NejcZdovc NejcZdovc mentioned this pull request Jan 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanml ryanml ryanml approved these changes

@jasonrsadler jasonrsadler Awaiting requested review from jasonrsadler

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.61.x - Release
Development

Successfully merging this pull request may close these issues.

Remove logs
2 participants
@NejcZdovc @ryanml