Use chromium's side panel inside our side bar container, and insert Reading List #13769

petemill · 2022-06-14T06:37:58Z

Chromium's side panel becomes controlled by Brave's side bar buttons, which uses chromium's side panel coordinator.

The goal of this PR is to get the best of both worlds - use Chromium's SidePanel related views, models, coordinators, WebContents management, and WebUI resources, whilst still using the awesome Brave SideBar from @simonhong.

There are many things we and chromium would like to use side panels for, and this could set us up to scale well for that.

Another change is that using the toolbar button to open side panel will result in the sidebar (and panel) staying open, even if the sidebar prefs are set to open on mouseover or never. Once the panel closes, then the sidebar will to if the prefs have either of these values.

Note: One consideration is to instead do the inverse of what I have done in this PR: Perhaps we move our SideBar to be a child of browser_view_->right_aligned_side_panel() (like the ComboBox is for Chromium) and have the toolbar button turn on SideBar + SidePanel, with no separation between the two. Some complication will need to be catered to where we want the SideBar to show even when there is no active SidePanel.

TODO

Resolves brave/brave-browser#17959

Future considerations:

Side search
Interaction with vertical tabs, and perhaps Side Bar + Side Panel moving to the right

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

On brave/brave-browser#17959

simonhong

Great to reuse upstream's side panel UI 👍🏼

common/extensions/api/_api_features.json

components/sidebar/sidebar_service.cc

components/sidebar/constants.h

simonhong · 2022-06-17T01:57:26Z

components/sidebar/sidebar_item.cc

@@ -4,24 +4,34 @@
 * You can obtain one at http://mozilla.org/MPL/2.0/. */

 #include "brave/components/sidebar/sidebar_item.h"
+#include "build/build_config.h"


nit: this seems not needed here?

simonhong · 2022-06-28T02:02:17Z

browser/ui/views/sidebar/sidebar_container_view.cc

-  constexpr size_t kPanelWidthForBuiltIn = 260;
-  constexpr size_t kPanelWidthForNonBuiltIn = 360;
-  return IsBuiltInType(item) ? kPanelWidthForBuiltIn : kPanelWidthForNonBuiltIn;
+SidePanelEntry::Id SidePanelIdFromSideBarItem(const sidebar::SidebarItem item) {


nit: const sidebar::SidebarItem& item

simonhong · 2022-06-28T02:41:31Z

browser/ui/sidebar/sidebar_model.h

  bool IsSidebarHasAllBuiltiInItems() const;
  int GetIndexOf(const SidebarItem& item) const;

-  // Don't cache web_contents. It can be deleted during the runtime.


From now, this SidebarModel's main role is managing active index and fetching favicon :)

simonhong · 2022-06-28T02:57:28Z

browser/ui/views/sidebar/sidebar_container_view.cc

-      sidebar_panel_webview_->SetVisible(true);
-      // When panel is opened, it will get focused.
-      sidebar_panel_webview_->RequestFocus();
+    if (!item.open_in_panel) {


nit: it would be more readable if positive condition comes first - if (item.open_in_panel).

simonhong · 2022-06-28T02:57:40Z

browser/ui/views/sidebar/sidebar_container_view.cc

    }
+    // if (item.open_in_panel) {


browser/ui/views/frame/brave_browser_view.cc

simonhong · 2022-06-28T03:16:03Z

browser/ui/views/sidebar/sidebar_container_view.cc

-  sidebar_panel_webview_ =
-      AddChildView(std::make_unique<SidebarPanelWebView>(browser_->profile()));
+
+  ReorderChildView(side_panel_, 1);


If we add sidebar_control_view_ at index 0, then maybe we don't need to reorder side_pane_?

sidebar_control_view_ = AddChildViewAt(std::make_unique<SidebarControlView>(browser_), 0);

petemill · 2022-07-12T15:24:25Z

I have now pushed all functionality working well with the new toolbar icon. The Sidebar correctly shows active states when the panel is made active from external means (i.e. the side panel toolbar icon).

Another change is that using the toolbar button to open side panel will result in the sidebar (and panel) staying open, even if the sidebar prefs are set to open on mouseover or never. Once the panel closes, then the sidebar will to if the prefs have either of these values.

~~The only item left for me at the moment is to update the vector icon from figma.~~

petemill · 2022-07-12T23:38:39Z

Test plans added to brave/brave-browser#17959

petemill · 2022-07-12T23:44:03Z

All feedback addressed @simonhong

brave-builds · 2022-07-12T23:45:11Z

A Storybook has been deployed to preview UI for the latest push

simonhong · 2022-07-13T07:11:39Z

I realized that SidebarService doesn't show newly introduced default item.
So existing user should add reading list item via add item bubble.
It should be handled as a separated issue.

simonhong · 2022-07-13T11:54:25Z

When any item is not activated after launching, clicking toolbar button opens always reading list (even it's removed item).
When readling list item is removed, I think another (bookmark) item should be activated.
If there are no visible items for panel, what should we do when clicks toolbar button?

also there is no border between web contens and panel when panel is opened via toolbar button after launching.

brave-builds · 2022-07-25T00:35:47Z

A Storybook has been deployed to preview UI for the latest push

petemill · 2022-07-25T21:29:37Z

@simonhong I've addressed feedback again and added / amended some tests as appropriate. Please re-review when you can.

I realized that SidebarService doesn't show newly introduced default item.
So existing user should add reading list item via add item bubble.
It should be handled as a separated issue.

I've handled that in this PR now. I migrated the prefs such that the existing pref only stores user items (not built-in). And I made a new pref which simply contains a list of IDs of built-in items which the user has hidden.

When any item is not activated after launching, clicking toolbar button opens always reading list (even it's removed item).
When readling list item is removed, I think another (bookmark) item should be activated.
If there are no visible items for panel, what should we do when clicks toolbar button?

This should now work as you describe. And if the user removes all panel items, then the toolbar icon will hide.

also there is no border between web contens and panel when panel is opened via toolbar button after launching.

This is fixed. The issue was the delay between sidebar item getting activated and sidepanel view being shown (due to waiting for load event).

brave-builds · 2022-07-25T22:17:41Z

A Storybook has been deployed to preview UI for the latest push

sangwoo108

Nice work!🙌

Sorry for being picky. Please feel free to give me feedbacks for my comments.

sangwoo108 · 2022-07-28T01:26:21Z

app/vector_icons/sidebar_reading_list.icon

@@ -0,0 +1,77 @@
+CANVAS_DIMENSIONS, 16,


Should we have copyright here?

sangwoo108 · 2022-07-28T01:34:15Z

browser/ui/sidebar/sidebar_browsertest.cc

  ASSERT_TRUE(
      ui_test_utils::NavigateToURL(browser(), GURL("brave://settings/")));

  EXPECT_TRUE(CanAddCurrentActiveTabToSidebar(browser()));
  controller()->AddItemWithCurrentTab();
-  // have 4 items.
-  EXPECT_EQ(4UL, model()->GetAllSidebarItems().size());
+  // Has 1 item.


Suggested change

// Has 1 item.

// Add 1 item.

or

Suggested change

// Has 1 item.

// Has 5 items.

browser/ui/sidebar/sidebar_controller.cc

sangwoo108 · 2022-07-28T02:14:06Z

browser/ui/sidebar/sidebar_model.cc

+  if (active_index_ == from) {
+    new_active_index = to;
+  }
+  if (active_index_ == to) {
+    new_active_index = (to < from) ? active_index_ + 1 : active_index_ - 1;
+  }
+  if (from > active_index_ && to < active_index_) {
+    new_active_index = active_index_ + 1;
+  }
+  UpdateActiveIndexAndNotify(new_active_index);


It seems from < active_index < to case isn't handled, where we should decrease active index by one.

How about collapsing conditions like this?

if (active_index_ == from) { new_active_index = to; } else { new_active_index = (to < from) ? active_index_ + 1 : active_index_ - 1; }

thanks - for some reason this was still working fine though 🤷

sangwoo108 · 2022-07-28T02:29:18Z

browser/ui/sidebar/sidebar_model.cc

+      std::find_if(items.begin(), items.end(), [item](const auto& i) {
+        return (item.built_in_item_type == i.built_in_item_type &&
+                item.url == i.url);
+      });


nit:

Let's use ranges

capturing reference can be better I think.

Suggested change

std::find_if(items.begin(), items.end(), [item](const auto& i) {

return (item.built_in_item_type == i.built_in_item_type &&

item.url == i.url);

});

base::ranges::find_if(items, [&item](const auto& i) {

return (item.built_in_item_type == i.built_in_item_type &&

item.url == i.url);

});

sangwoo108 · 2022-07-28T05:21:32Z

components/sidebar/sidebar_service.cc

+    // Remember not to hide this item
+    auto iter = std::find_if(
+        built_in_items_to_hide.begin(), built_in_items_to_hide.end(),
+        [item_id](const auto& default_item) {


same with comment above, & capture and ranges.

sangwoo108 · 2022-07-28T05:36:55Z

components/sidebar/sidebar_service.cc

@@ -225,75 +350,133 @@ SidebarService::ShowSidebarOption SidebarService::GetSidebarShowOption() const {
  return static_cast<ShowSidebarOption>(prefs_->GetInteger(kSidebarShowOption));
 }

+absl::optional<SidebarItem> SidebarService::GetDefaultPanelItem() const {
+  const std::vector<SidebarItem::BuiltInItemType> preferred_item_types{


ditto: NoDestructor

sangwoo108 · 2022-07-28T05:42:12Z

components/sidebar/sidebar_service.cc

+      SidebarItem::BuiltInItemType::kBookmarks};
+  absl::optional<SidebarItem> default_item;
+  for (const auto& type : preferred_item_types) {
+    auto found_item_iter = std::find_if(


sangwoo108 · 2022-07-28T05:46:16Z

components/sidebar/sidebar_service.cc

+      if (type == SidebarItem::Type::kTypeBuiltIn) {
+        if (const auto value =
+                item.FindIntKey(kSidebarItemBuiltInItemTypeKey)) {
+          auto id = static_cast<SidebarItem::BuiltInItemType>(*value);


Suggested change

auto id = static_cast<SidebarItem::BuiltInItemType>(*value);

auto type = static_cast<SidebarItem::BuiltInItemType>(*value);

components/sidebar/sidebar_service.cc

mkarolin · 2022-07-28T14:54:49Z

chromium_src/chrome/browser/ui/views/side_search/side_search_browser_controller.cc

+// License, v. 2.0. If a copy of the MPL was not distributed with this file,
+// you can obtain one at http://mozilla.org/MPL/2.0/.
+
+// Need to include this header here otherwise SidePanel macro gets undef'ed


Typically we include the corresponding header first to prevent the redefinitions. Should
#include "chrome/browser/ui/views/side_search/side_search_browser_controller.h" here?

Seems like we also need to keep the browser_view.h include as that also has a macro called SidePanel

mkarolin · 2022-07-28T14:58:07Z

chromium_src/chrome/browser/ui/views/frame/browser_view.cc

@@ -3,16 +3,24 @@
 * License, v. 2.0. If a copy of the MPL was not distributed with this file,
 * You can obtain one at http://mozilla.org/MPL/2.0/. */

+#include "brave/browser/ui/views/frame/brave_browser_view_layout.h"


Should include "chrome/browser/ui/views/frame/browser_view.h" first?

brave-builds · 2022-08-16T01:32:46Z

A Storybook has been deployed to preview UI for the latest push

petemill · 2022-08-16T07:43:36Z

@sangwoo108 @mkarolin @simonhong thanks for the reviews - feedback is addressed again. Changes can be seen here: https://github.com/brave/brave-core/compare/45e5419e2c160c5a7cef1c0e5735a4329f2d670e..4ffd577477

brave-builds · 2022-08-16T08:52:32Z

A Storybook has been deployed to preview UI for the latest push

simonhong

++ it seems only network audit test should be fixed :)

simonhong · 2022-08-18T05:44:04Z

components/sidebar/sidebar_service.cc

@@ -63,34 +76,22 @@ SidebarItem GetBuiltInItemForType(SidebarItem::BuiltInItemType type) {
  return SidebarItem();
 }

-SidebarItem::BuiltInItemType GetBuiltInItemTypeForURL(const std::string& url) {


Thanks for deleting obsolete functions!

petemill · 2022-08-19T00:54:56Z

Updated to fix network audit test, review changes can now be seen at https://github.com/brave/brave-core/compare/45e5419e2c160c5a7cef1c0e5735a4329f2d670e..4ffd577477

brave-builds · 2022-08-19T01:56:41Z

A Storybook has been deployed to preview UI for the latest push

sangwoo108 · 2022-08-19T05:17:26Z

browser/ui/sidebar/sidebar_model.cc

 bool SidebarModel::IsSidebarHasAllBuiltiInItems() const {
  return GetSidebarService(profile_)->GetHiddenDefaultSidebarItems().empty();
 }

 int SidebarModel::GetIndexOf(const SidebarItem& item) const {
  const auto items = GetAllSidebarItems();
  const auto iter =
-      std::find_if(items.begin(), items.end(),
-                   [item](const auto& i) { return item.url == i.url; });
+      base::ranges::find_if(items.begin(), items.end(), [&item](const auto& i) {


When you use ranges, I think you can omit begin(), end() of container.

Suggested change

base::ranges::find_if(items.begin(), items.end(), [&item](const auto& i) {

base::ranges::find_if(items, [&item](const auto& i) {

sangwoo108 · 2022-08-19T05:25:28Z

components/sidebar/sidebar_service.cc

+    }
+    // Remember not to hide this item
+    auto iter = base::ranges::find_if(
+        built_in_items_to_hide.begin(), built_in_items_to_hide.end(),


ditto:

Suggested change

built_in_items_to_hide.begin(), built_in_items_to_hide.end(),

built_in_items_to_hide,

sangwoo108 · 2022-08-19T05:25:52Z

components/sidebar/sidebar_service.cc

-                                      added_item.built_in_item_type;
-                             });
+    auto iter =
+        base::ranges::find_if(default_items.begin(), default_items.end(),


ditto:

Suggested change

base::ranges::find_if(default_items.begin(), default_items.end(),

base::ranges::find_if(default_items,

sangwoo108 · 2022-08-19T05:26:17Z

components/sidebar/sidebar_service.cc

+  absl::optional<SidebarItem> default_item;
+  for (const auto& type : *preferred_item_types) {
+    auto found_item_iter = base::ranges::find_if(
+        items_.begin(), items_.end(),


ditto:

Suggested change

items_.begin(), items_.end(),

items_,

sangwoo108 · 2022-08-19T05:36:35Z

browser/ui/views/sidebar/sidebar_container_view.h

  void OnActiveIndexChanged(int old_index, int new_index) override;
+  void OnItemRemoved(int index) override;
+
+  // SidePanelEntryObserver:


How about having base::ScopedObservation<SidePanelEntry, SidePanelEntryObserver> as member variable for this?

I think there's no RemoveObserver() call for SidebarPanelEntry and that could be guaranteed by this RAII object.

sangwoo108 · 2022-08-19T05:38:57Z

browser/ui/views/sidebar/sidebar_container_view.h

+
+  // SidePanelRegistryObserver:
+  void OnEntryRegistered(SidePanelEntry* entry) override;
+  void OnEntryWillDeregister(SidePanelEntry* entry) override;


And how about having base::ScopedMultiSourceObservation? For similar reason.

sangwoo108 · 2022-08-19T05:40:06Z

browser/ui/views/sidebar/sidebar_control_view.h

@@ -85,6 +93,7 @@ class SidebarControlView : public views::View,
  void UpdateSettingsButtonState();
  void UpdateBackgroundAndBorder();

+  raw_ptr<Delegate> delegate_;


nit: for consistency

Suggested change

raw_ptr<Delegate> delegate_;

raw_ptr<Delegate> delegate_ = nullptr;

components/sidebar/sidebar_service.cc

sangwoo108 · 2022-08-19T05:47:21Z

components/sidebar/sidebar_service.cc

-
-SidebarItem GetBuiltInItemForURL(const std::string& url) {
-  return GetBuiltInItemForType(GetBuiltInItemTypeForURL(url));
+std::vector<SidebarItem::BuiltInItemType> GetDefaultBuiltInItemTypes() {


How about returning const& in order to avoid copying the entire vector?

Suggested change

std::vector<SidebarItem::BuiltInItemType> GetDefaultBuiltInItemTypes() {

const std::vector<SidebarItem::BuiltInItemType>& GetDefaultBuiltInItemTypes() {

thanks for this nuance!

sangwoo108 · 2022-08-19T05:48:02Z

components/sidebar/sidebar_service.cc

+  // Add the items the user has never seen (or never persisted).
+  // Get the initial order of items so that we can attempt to
+  // insert at the intended order.
+  auto default_item_types = GetDefaultBuiltInItemTypes();


If GetDefaultBuiltInItemTypes returns const&, const auto& will be better.

Suggested change

auto default_item_types = GetDefaultBuiltInItemTypes();

const auto& default_item_types = GetDefaultBuiltInItemTypes();

sangwoo108

LGTM with nits 👍

petemill · 2022-08-19T20:07:05Z

@sangwoo108 I addressed your welcome nits via https://github.com/brave/brave-core/compare/4ffd577477..650d1c300b - thanks!

brave-builds · 2022-08-19T21:11:34Z

A Storybook has been deployed to preview UI for the latest push

…eading List Chromium's side panel is controlled by Brave's side bar buttons, via chromium's side panel coordinator

…e" to "exclusive" This allows new items to be easily added, and only store the item ref by ID instead of all item details

…ides if none are added

brave-builds · 2022-08-19T23:33:43Z

A Storybook has been deployed to preview UI for the latest push

petemill requested review from bsclifton and simonhong June 14, 2022 06:37

petemill requested review from a team as code owners June 14, 2022 06:37

petemill self-assigned this Jun 14, 2022

github-actions bot added CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Jun 14, 2022

petemill force-pushed the chromium-side-panel branch 2 times, most recently from 6b46214 to 1efc150 Compare June 17, 2022 04:23

petemill force-pushed the chromium-side-panel branch from 1efc150 to c1b6219 Compare June 21, 2022 17:48

simonhong reviewed Jun 28, 2022

View reviewed changes

petemill force-pushed the chromium-side-panel branch 2 times, most recently from cfc808a to e942a31 Compare July 12, 2022 15:21

petemill requested a review from simonhong July 12, 2022 15:24

petemill force-pushed the chromium-side-panel branch 3 times, most recently from 2413b2f to aa7ef88 Compare July 12, 2022 23:16

simonhong mentioned this pull request Jul 15, 2022

Rebase test playlist webui components/playlist/resources and others brave/brave-browser#24027

Closed

petemill force-pushed the chromium-side-panel branch 2 times, most recently from 4a89ca6 to 691bc97 Compare July 25, 2022 21:24

simonhong requested a review from sangwoo108 July 27, 2022 23:17

sangwoo108 reviewed Jul 28, 2022

View reviewed changes

mkarolin reviewed Jul 28, 2022

View reviewed changes

petemill force-pushed the chromium-side-panel branch from 785b41f to 45e5419 Compare August 16, 2022 00:27

petemill force-pushed the chromium-side-panel branch from 45e5419 to b1d5662 Compare August 16, 2022 07:42

petemill requested a review from iefremov as a code owner August 16, 2022 07:42

simonhong approved these changes Aug 18, 2022

View reviewed changes

petemill force-pushed the chromium-side-panel branch from b1d5662 to 4ffd577 Compare August 19, 2022 00:53

sangwoo108 reviewed Aug 19, 2022

View reviewed changes

sangwoo108 approved these changes Aug 19, 2022

View reviewed changes

iefremov approved these changes Aug 19, 2022

View reviewed changes

petemill force-pushed the chromium-side-panel branch from 4ffd577 to 650d1c3 Compare August 19, 2022 20:05

petemill added 3 commits August 19, 2022 15:37

Use chromium's side panel inside our side bar container, and insert R…

1bb9e9c

…eading List Chromium's side panel is controlled by Brave's side bar buttons, via chromium's side panel coordinator

sidebar: migrate pref for which built-in items to show from "inclusiv…

54599e7

…e" to "exclusive" This allows new items to be easily added, and only store the item ref by ID instead of all item details

Toolbar SidePanel button only opens items added on the sidebar, and h…

fd2a6b3

…ides if none are added

petemill force-pushed the chromium-side-panel branch from 650d1c3 to fd2a6b3 Compare August 19, 2022 22:37

petemill merged commit 5245ef4 into master Aug 22, 2022

petemill deleted the chromium-side-panel branch August 22, 2022 23:09

github-actions bot added this to the 1.44.x - Nightly milestone Aug 22, 2022

petemill mentioned this pull request Aug 25, 2022

Browser crashes at startup if sidebar pref has old format brave/brave-browser#24965

Closed

bsclifton mentioned this pull request Sep 14, 2022

Add Reading List in Brave brave/brave-browser#15583

Closed

	auto id = static_cast<SidebarItem::BuiltInItemType>(*value);
	auto type = static_cast<SidebarItem::BuiltInItemType>(*value);

	base::ranges::find_if(items.begin(), items.end(), [&item](const auto& i) {
	base::ranges::find_if(items, [&item](const auto& i) {

	built_in_items_to_hide.begin(), built_in_items_to_hide.end(),
	built_in_items_to_hide,

	base::ranges::find_if(default_items.begin(), default_items.end(),
	base::ranges::find_if(default_items,

	raw_ptr<Delegate> delegate_;
	raw_ptr<Delegate> delegate_ = nullptr;

	std::vector<SidebarItem::BuiltInItemType> GetDefaultBuiltInItemTypes() {
	const std::vector<SidebarItem::BuiltInItemType>& GetDefaultBuiltInItemTypes() {

	auto default_item_types = GetDefaultBuiltInItemTypes();
	const auto& default_item_types = GetDefaultBuiltInItemTypes();

Use chromium's side panel inside our side bar container, and insert Reading List #13769

Use chromium's side panel inside our side bar container, and insert Reading List #13769

Conversation

petemill commented Jun 14, 2022 • edited Loading

TODO

Future considerations:

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

simonhong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petemill commented Jul 12, 2022 • edited Loading

petemill commented Jul 12, 2022

petemill commented Jul 12, 2022

brave-builds commented Jul 12, 2022

simonhong commented Jul 13, 2022 • edited Loading

simonhong commented Jul 13, 2022 • edited Loading

brave-builds commented Jul 25, 2022

petemill commented Jul 25, 2022

brave-builds commented Jul 25, 2022

sangwoo108 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brave-builds commented Aug 16, 2022

petemill commented Aug 16, 2022 • edited Loading

brave-builds commented Aug 16, 2022

simonhong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petemill commented Aug 19, 2022

brave-builds commented Aug 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sangwoo108 left a comment • edited Loading

Choose a reason for hiding this comment

petemill commented Aug 19, 2022

brave-builds commented Aug 19, 2022

brave-builds commented Aug 19, 2022

petemill commented Jun 14, 2022 •

edited

Loading

petemill commented Jul 12, 2022 •

edited

Loading

simonhong commented Jul 13, 2022 •

edited

Loading

simonhong commented Jul 13, 2022 •

edited

Loading

petemill commented Aug 16, 2022 •

edited

Loading

sangwoo108 left a comment •

edited

Loading