Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farble Accept-Language header on subresources #14338

Merged
merged 11 commits into from
Aug 4, 2022

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jul 26, 2022

Resolves brave/brave-browser#24282

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jul 26, 2022
@pilgrim-brave pilgrim-brave marked this pull request as draft July 26, 2022 17:48
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_accept_language_subresources branch from b5030aa to c2c4c5b Compare July 26, 2022 20:20
@pilgrim-brave pilgrim-brave marked this pull request as ready for review July 26, 2022 20:39
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_accept_language_subresources branch from 5e9e2c7 to d9d4384 Compare August 3, 2022 15:36
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_accept_language_subresources branch from 335ed7a to d3c8ea8 Compare August 4, 2022 14:14
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak
Copy link
Member

kjozwiak commented Aug 16, 2022

Reproduced the original issue @pilgrim-brave mentioned via brave/brave-browser#24282 (comment) using the following STR/Cases:

  • installed 1.44.22 Chromium: 104.0.5112.81
  • restarted the browser and ensured that DisableReduceLanguage:Enabled
  • double checked and ensured that Prevent sites from fingerprinting me based on my language preferences was enabled via brave://settings/shields
  • added several languages via brave://settings/languages
  • visited https://dev-pages.brave.software/index.html and opened the DevTools
  • under the Network tab, clicked on Disable cache
  • refreshed https://dev-pages.brave.software/index.html once again
Farbled Not farbled Not farbled
reproduced1 reproduced2 reproduced3

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.44.45 Chromium: 104.0.5112.81 (Official Build) nightly (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.856)

Used the same STR/Cases outlined above and ensured that accept-language was being farbled on all the files under https://dev-pages.brave.software/index.html as per the following:

Languages selected Farbled Farbled Farbled
language fixed1 fixed2 fixed3

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.44.49 Chromium: 104.0.5112.81 (Official Build) canary (32-bit)
--- | ---
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Android 12; Build/SP1A.210812.016
Languages FP Disabled FP Default FB Strict
Screenshot_20220817-003841_Settings Screenshot_20220817-004136_Brave - Nightly Screenshot_20220817-004102_Brave - Nightly Screenshot_20220817-004117_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Language not farbling HTTP headers of subresources
5 participants