Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ads staging flag uses brave.com domain #14583

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Fixes ads staging flag uses brave.com domain #14583

merged 1 commit into from
Aug 11, 2022

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 10, 2022

Resolves brave/brave-browser#24574

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tmancey tmancey self-assigned this Aug 10, 2022
@tmancey tmancey requested review from a team as code owners August 10, 2022 23:25
@tmancey tmancey force-pushed the issues/24574 branch 2 times, most recently from 3648205 to 670ab13 Compare August 11, 2022 14:25
@tmancey tmancey marked this pull request as draft August 11, 2022 14:35
@tmancey tmancey marked this pull request as ready for review August 11, 2022 14:58
@tmancey tmancey requested a review from zenparsing August 11, 2022 15:01
@tmancey tmancey marked this pull request as draft August 11, 2022 15:05
@tmancey tmancey marked this pull request as ready for review August 11, 2022 15:15
@tmancey tmancey merged commit ba41a46 into master Aug 11, 2022
@tmancey tmancey deleted the issues/24574 branch August 11, 2022 18:52
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ads staging flag uses brave.com domain
4 participants