Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Sync (beta)" text #1461

Closed
wants to merge 1 commit into from
Closed

Revert "Sync (beta)" text #1461

wants to merge 1 commit into from

Conversation

bsclifton
Copy link
Member

Uplift of #1458

@bsclifton
Revert "Merge pull request #1441 from brave/sync-title-update"
567c7ef 
This reverts commit 3e952ba, reversing
changes made to eefa3f7.
@bsclifton bsclifton added this to the 0.59.x - Release milestone Jan 25, 2019
@bsclifton bsclifton self-assigned this Jan 25, 2019
@bbondy
Copy link
Member

bbondy commented Jan 25, 2019

This will blow away all the localization. Do we prefer to have english Sync or localized Sync (beta)?

@NejcZdovc
Copy link
Contributor

@bbondy did we got new translations since #1441 landed in 0.59 yesterday? If not then I think they are already blown

@bbondy
Copy link
Member

bbondy commented Jan 25, 2019

Yes an order was put in yesterday. There won't be time for another for 0.59.x

@NejcZdovc
Copy link
Contributor

oh ok, then yeah this is a hard one

@bsclifton bsclifton closed this Jan 25, 2019
@bsclifton bsclifton deleted the 0.59.x-revert-beta-title branch January 25, 2019 20:22
@btlechowski btlechowski mentioned this pull request Jan 25, 2022
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy Awaiting requested review from bbondy

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @bbondy @NejcZdovc