Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebTorrent first load of magnet links #14866

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#24552

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

If the page loads, the fix has worked. Note: This bug only shows up if this is the first launch of WebTorrent in a profile AND the first launch is via a magnet link.

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Aug 28, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fallaciousreasoning fallaciousreasoning merged commit 9d98c43 into master Aug 29, 2022
@fallaciousreasoning fallaciousreasoning deleted the wt-fix-magnet branch August 29, 2022 22:03
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasionally WebTorrent fails to load the first time you click on a link (refreshing fixes the issue).
3 participants