Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always pass "Background Wallpaper" even when we use "Sponsored image" #15119

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Always pass "Background Wallpaper" even when we use "Sponsored image" #15119

merged 2 commits into from
Sep 19, 2022

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Sep 16, 2022 •
edited
Loading

This data is required for Background chooser to be able to know which wallpaper is currently set.

Resolves brave/brave-browser#25398

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Select a gradient or solid color background
  2. Open new tabs until a new tab has SI background
  3. Open background setting page
  4. A gradient or solid color category should be selected, not Brave background

@sangwoo108 sangwoo108 marked this pull request as ready for review September 16, 2022 12:28
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 16, 2022
@sangwoo108
Always pass "Background Wallpaper" even when we use "Sponsored image"
7013f92 
This data is required for Background chooser to be able to know
which wallpaper is currently set.
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@sangwoo108
Copy link
Contributor Author

@simonhong Could you take a look at this please?

simonhong
simonhong approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

browser/ui/webui/new_tab_page/brave_new_tab_message_handler.cc Outdated
wallpaper.Set(kBackgroundWallpaperKey, std::move(*data));
ResolveJavascriptCallback(args[0], base::Value(std::move(wallpaper)));
return;
}

// Even though we show sponsored image, we should pass "Background wallpaper"
// data so that NTP can know which wallpaper is selected by users.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: NTP customization menu would be better for understanding instead of NTP?

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@sangwoo108 sangwoo108 merged commit 34235a6 into master Sep 19, 2022
@sangwoo108 sangwoo108 deleted the sko/si-selection branch September 19, 2022 06:58
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 19, 2022
@sangwoo108
Copy link
Contributor Author

Filled reviewer's checklist on behalf of @simonhong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhong simonhong simonhong approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@sangwoo108 sangwoo108

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging this pull request may close these issues.

Background Selection state is wrong when SI background is shown
3 participants
@sangwoo108 @brave-builds @simonhong