Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Brave Wallet by policy #15252

Merged
merged 7 commits into from
Sep 30, 2022
Merged

Disable Brave Wallet by policy #15252

merged 7 commits into from
Sep 30, 2022

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#25383

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Sep 27, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Sep 27, 2022
@mkarolin mkarolin force-pushed the maxk-disable-wallet-by-policy branch 2 times, most recently from d34df97 to 154d802 Compare September 28, 2022 18:37
@mkarolin mkarolin requested a review from simonhong September 28, 2022 18:39
@mkarolin mkarolin marked this pull request as ready for review September 28, 2022 18:43
@mkarolin mkarolin requested review from a team as code owners September 28, 2022 18:43
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add test steps.
I tested manually by adding policy files (/etc/brave/policies/managed/00_wallet.json) with below contents on linux

{
	"BraveWalletDisabled": true
}

components/sidebar/sidebar_service.cc Outdated Show resolved Hide resolved
components/sidebar/sidebar_service.cc Outdated Show resolved Hide resolved
components/brave_wallet/common/pref_names.h Outdated Show resolved Hide resolved
browser/brave_wallet/brave_wallet_policy_browsertest.cc Outdated Show resolved Hide resolved
@mkarolin
Copy link
Collaborator Author

It would be good to add test steps. I tested manually by adding policy files (/etc/brave/policies/managed/00_wallet.json) with below contents on linux

{
	"BraveWalletDisabled": true
}

Thanks @simonhong! I've updated the test plan in brave/brave-browser#25383

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 👍🏼

@mkarolin mkarolin force-pushed the maxk-disable-wallet-by-policy branch from 905de1e to 1d995e8 Compare September 30, 2022 13:53
@mkarolin
Copy link
Collaborator Author

Rebased on master and squashed fixups.

@mkarolin mkarolin merged commit 3bdf885 into master Sep 30, 2022
@mkarolin mkarolin deleted the maxk-disable-wallet-by-policy branch September 30, 2022 17:55
@mkarolin mkarolin added this to the 1.46.x - Nightly milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a policy option to disable Brave Wallet
4 participants