Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wallet qr address and link color per theme #15319

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

Pavneet-Sing
Copy link

@Pavneet-Sing Pavneet-Sing commented Oct 3, 2022

add lint warning details

Resolves brave/brave-browser#25731
Resolves brave/brave-browser#25224
Resolves brave/brave-browser#25388

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

address-issue.webm

@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Oct 3, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Oct 3, 2022
@Pavneet-Sing Pavneet-Sing force-pushed the handle-wallet-address-qr-code branch 2 times, most recently from fbb976b to 503dafd Compare October 3, 2022 13:30
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Pavneet-Sing Pavneet-Sing merged commit ace64d9 into master Oct 3, 2022
@Pavneet-Sing Pavneet-Sing deleted the handle-wallet-address-qr-code branch October 3, 2022 18:14
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
3 participants