Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Polymer override for personalization page in brave://settings #15476

Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 14, 2022

Resolves brave/brave-browser#26050

Just an oversight, looks like this page was still using <dom-module> and not inserting the template.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick requested review from petemill and mkarolin October 14, 2022 23:29
@emerick emerick self-assigned this Oct 14, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 14, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick emerick merged commit ad98457 into master Oct 15, 2022
@emerick emerick deleted the cr107-followup-personalization-page-missing-settings branch October 15, 2022 11:17
@emerick emerick added this to the 1.46.x - Nightly milestone Oct 15, 2022
emerick added a commit that referenced this pull request Oct 15, 2022
…age-missing-settings

Fix broken Polymer override for personalization page in brave://settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebRTC IP handling policy entry is not shown in brave://settings/security in Nightly w/ Chromium 107
3 participants