Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when creating new profile #15483

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 17, 2022

Resolves brave/brave-browser#26044

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick requested a review from simonhong October 17, 2022 13:49
@emerick emerick requested a review from a team as a code owner October 17, 2022 13:49
@emerick emerick self-assigned this Oct 17, 2022
@emerick emerick force-pushed the cr107-followup-fix-create-profiles-crash branch from 36edeef to dd769ea Compare October 17, 2022 17:21
@emerick emerick requested review from yrliou and darkdh and removed request for simonhong October 17, 2022 17:23
@emerick emerick merged commit 84ff022 into master Oct 17, 2022
@emerick emerick deleted the cr107-followup-fix-create-profiles-crash branch October 17, 2022 20:27
@emerick emerick added this to the 1.46.x - Nightly milestone Oct 17, 2022
emerick added a commit that referenced this pull request Oct 17, 2022
…es-crash

Fix crash when creating new profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave crashed when creating new profiles on Nightly w/ Chromium 107
2 participants