Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brave-typical profile #15594

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Update brave-typical profile #15594

merged 1 commit into from
Oct 21, 2022

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Oct 21, 2022

Resolves brave/brave-browser#26167
This is a necessary update of the profile to fix adblock in recent nightly build.
The reason is that browser starts to use new components after #15077

Added components:

Brave Ad Block List Catalog - Version: 1.0.30
./gkboaolpopklhgplhaaiboijnklogmbc/1.0.30

Brave Ad Block Resources Library - Version: 1.0.34
./mfddibmblmbccpadfndgakiopmmhebop/1.0.34

Brave Ad Block Updater - Version: 1.0.62
iodkpdagapdfkphljnddpjlldadblomo/1.0.62

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m self-assigned this Oct 21, 2022
@atuchin-m atuchin-m requested a review from goodov October 21, 2022 13:33
@atuchin-m atuchin-m merged commit 568cb16 into master Oct 21, 2022
@atuchin-m atuchin-m deleted the update-brave-typical-profile branch October 21, 2022 15:37
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken adblock in brave typical perf tests
2 participants