Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News] Fix bug where direct feeds didn't show up as followed #16086

Merged
merged 2 commits into from
Nov 27, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

Follow up for #15963, which fixed it's original issue but broke the button toggle state.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. With #brave-news-subscribe-button enabled
  2. Navigate to theatlantic.com
  3. Follow Best of the Atlantic
  4. The button state should update

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

browser/brave_news/brave_news_tab_helper.cc Outdated Show resolved Hide resolved
@stephendonner
Copy link
Contributor

While initially trying to test this for uplift, I encountered brave/brave-browser#27052, just FYI for now.

@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.48.15 Chromium: 108.0.5359.62 (Official Build) nightly (x86_64)
Revision 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.48.15
  2. launched Brave
  3. opened brave://flags
  4. confirmed no Brave News button flag exists
  5. loaded theatlantic.com
  6. clicked on the RSS-feed icon in the URL bar
  7. clicked on Best of the Atlantic 's Follow button
  8. waited

Confirmed the Follow / Unfollow button state is accurately reflected

brave://flags theatlantic.com Follow Unfollow
Screen Shot 2022-11-29 at 5 11 49 PM Screen Shot 2022-11-29 at 5 11 59 PM Screen Shot 2022-11-29 at 5 12 04 PM Screen Shot 2022-11-29 at 5 12 14 PM

NOTE: logged brave/brave-browser#27052 while testing

@fallaciousreasoning
Copy link
Contributor Author

Note: I think brave/brave-browser#27052 was introduced by #16038, so the fix for that will need an uplift too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants