Create new npm run pr task
#1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
force-pushed
the
npm-run-pr
branch
2 times, most recently
from
3eb35cc
to
6214659
Compare
|
@bsclifton this is awesome. Maybe we could add support for labels as well? |
|
@NejcZdovc already in the works! Stay tuned 😄 😄 😄 |
bsclifton
force-pushed
the
npm-run-pr
branch
2 times, most recently
from
d7f4af3
to
ef643b8
Compare
|
Lots more progress made here - would be good to have some folks try it 😄 I think it might be "done" enough for a first revision edit: @NejcZdovc DONE! |
bsclifton
force-pushed
the
npm-run-pr
branch
from
385b213
to
271422d
Compare
Only works for brave-core (Desktop). New script will create branches / PRs as needed to uplift to a given channel. Also allows assignment of reviewers / assignees (including login validation) Fixes brave/devops#672
…and `--force` parameters
Also, each PR created is opened in the default browser
This does the following: - fetches the PR in question - creates a local branch with the content of the PR - does the rest of the process normally Handy since you don't need to actually have the code locally in order to uplift
bsclifton
force-pushed
the
npm-run-pr
branch
from
271422d
to
983ce6a
Compare
bsclifton
added a commit
to brave/brave-browser
that referenced
this pull request
Feb 13, 2019
…ncluding uplifts) Accompanies brave/brave-core#1632 Helps to fix brave/devops#672
This was referenced Feb 13, 2019
bsclifton
added a commit
that referenced
this pull request
Feb 13, 2019
- version check is no longer done; this caused problems because it's comparing brave-browser against brave-core - PR uplift wasn't using the SHA- which means it didn't find any commits when doing compare (ex: it did master against master)
bsclifton
added a commit
that referenced
this pull request
Feb 13, 2019
- version check is no longer done; this caused problems because it's comparing brave-browser against brave-core - PR uplift wasn't using the SHA- which means it didn't find any commits when doing compare (ex: it did master against master)
bsclifton
added a commit
to brave/brave-browser
that referenced
this pull request
Feb 14, 2019
…ncluding uplifts) Accompanies brave/brave-core#1632 Helps to fix brave/devops#672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only works for brave-core (Desktop). New script will create branches / PRs as needed to uplift to a given channel.
Also allows assignment of reviewers / assignees / milestone / labels
Fixes brave/devops#672
Example command line usage(s):
NOTE: you can either pass the token in as an environment variable OR put it in your
~/.npmrc. Either way would work. The NAME of the variable needs to be:BRAVE_GITHUB_TOKENCreate 4 PRs, based on your local branch (which would be branched from master). One for master (
nightly),dev,beta, and finallyrelease. Will set the reviewers as @bbondy and @petemill and the assignee as @bsclifton./script/pr.py --reviewers=bbondy,petemill --owners=bsclifton --uplift-to=releaseSame as above, but don't actually submit the PRs (dry run):
./script/pr.py --reviewers=bbondy,petemill --owners=bsclifton --dry-run --uplift-to=releaseSubmit 3 PRs. Use case would be that master already has a PR up and now it's time to start the uplift process:
./script/pr.py --reviewers=bbondy,petemill --owners=bsclifton --uplift-to=release --start-from=devGet more verbose output (otherwise, same as number 3 above):
./script/pr.py --reviewers=bbondy,petemill --owners=bsclifton --uplift-to=release --start-from=dev --verboseShow all possible parameters (with description):
./script/pr.py --helpUplift an already existing pull request (Create new
npm run prtask #1632) to dev../script/pr.py --reviewers=bbondy,petemill,NejcZdovc --owners=bsclifton --uplift-to=dev --labels=ui --dry-run --uplift-using-pr=1632Example use-cases
--uplift-to=beta. A PR will then be created againstmaster,dev, andbeta.masterand it was approved/merged. You now need to merge this to RELEASE. You can specify----uplift-using-pr=12345(putting the actual PR number), along with--uplift-to=releaseand--start-from=dev(since master was already approved). A PR would then be created againstdev,beta, andrelease.Notes
masteris determined by looking at the package.json inbrave-browser. For example,0.62.0will map itself to the milestone0.62.x--verbose--dry-run--title--labels(comma separated list)