Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm-run-pr (uplift to 0.60.x) #1653

Closed
wants to merge 4 commits into from
Closed

npm-run-pr (uplift to 0.60.x) #1653

wants to merge 4 commits into from

Commits on Feb 13, 2019

  1. Create new npm run pr task 

    Only works for brave-core (Desktop). New script will create branches / PRs as needed to uplift to a given channel.
Also allows assignment of reviewers / assignees (including login validation)

Fixes brave/devops#672
    @bsclifton
    bsclifton committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    cfd04fc View commit details
    Browse the repository at this point in the history

  2. Fixed bugs when using starts-from and added --labels, --title, … 

    …and `--force` parameters
    @bsclifton
    bsclifton committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    677f061 View commit details
    Browse the repository at this point in the history

  3. Script now considers npm config when looking for GitHub token 

    Also, each PR created is opened in the default browser
    @bsclifton
    bsclifton committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    4935c4a View commit details
    Browse the repository at this point in the history

  4. Added new uplift_using_pr option 

    This does the following:
- fetches the PR in question
- creates a local branch with the content of the PR
- does the rest of the process normally

Handy since you don't need to actually have the code locally in order to uplift
    @bsclifton
    bsclifton committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    7a7fc39 View commit details
    Browse the repository at this point in the history