You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use eth_subscribe to listen for new logs. You should see a console message in the developer console matching the same subscription ID every 20 seconds. You can subscribe multiple times, each time will give a new subscription ID.
Ex: window.ethereum.on('message', (x, y, z) => console.log('message event: ', x, y, z)) window.ethereum.send({ id:5, method: 'eth_subscribe', params:["logs"]}, console.log)
Use eth_unsubscribe to stop listening to an event by putting the subscription ID from the eth_subscribe call. It should stop ending events and return true to the console when you unsubscribe successfully from something.
window.ethereum.on('message', (x, y, z) => console.log('message event: ', x, y, z)) window.ethereum.send({ id:5, method: 'eth_unsubscribe', params:["0x0b4fcbf913cf950c936489965ba189df"]}, console.log)
where 0x0b4fcbf913cf950c936489965ba189df - subscription identifier returned by subscription method
⚠️ PR head is an unsigned commit
commit: a17df8933eb47772e705e4942204f1fc911dd055
reason: no_user
Please follow the handbook to configure commit signing
cc: @null
⚠️ PR head is an unsigned commit
commit: a17df8933eb47772e705e4942204f1fc911dd055
reason: no_user
Please follow the handbook to configure commit signing
cc: @null
⚠️ PR head is an unsigned commit
commit: cbc12f7da649d4735db6f309f102f0199a83d997
reason: no_user
Please follow the handbook to configure commit signing
cc: @null
⚠️ PR head is an unsigned commit
commit: 57d5d5beeaffdf7eeaf97f3f718f791c4515be27
reason: no_user
Please follow the handbook to configure commit signing
cc: @null
⚠️ PR head is an unsigned commit
commit: 57d5d5beeaffdf7eeaf97f3f718f791c4515be27
reason: no_user
Please follow the handbook to configure commit signing
cc: @null
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vadimstruts
force-pushed
the
27283-support-eth_subscribe-with-logs-param
branch
from
This extends support for a
eth_subscribemethod that can be used in Ethereum provider requests.See a description of this here: https://docs.infura.io/infura/networks/ethereum/json-rpc-methods/subscription-methods/eth_subscribe
In addition to previously implemented
newHeads(brave/brave-browser#21350), this adds newlogsparameter support, but for now filtering options is not supported. It requires the follow up implementationResolves brave/brave-browser#27283
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Use
eth_subscribeto listen for new logs. You should see a console message in the developer console matching the same subscription ID every 20 seconds. You can subscribe multiple times, each time will give a new subscription ID.Ex:
window.ethereum.on('message', (x, y, z) => console.log('message event: ', x, y, z)) window.ethereum.send({ id:5, method: 'eth_subscribe', params:["logs"]}, console.log)Use
eth_unsubscribeto stop listening to an event by putting the subscription ID from theeth_subscribecall. It should stop ending events and return true to the console when you unsubscribe successfully from something.window.ethereum.on('message', (x, y, z) => console.log('message event: ', x, y, z)) window.ethereum.send({ id:5, method: 'eth_unsubscribe', params:["0x0b4fcbf913cf950c936489965ba189df"]}, console.log)where
0x0b4fcbf913cf950c936489965ba189df- subscription identifier returned by subscription method