-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] fix news ntp gps crash #16890
Conversation
if (itemAnimator instanceof SimpleItemAnimator) { | ||
SimpleItemAnimator simpleItemAnimator = (SimpleItemAnimator) itemAnimator; | ||
simpleItemAnimator.setSupportsChangeAnimations(false); | ||
if (mActivity != null && !mActivity.isDestroyed() && !mActivity.isFinishing()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a minor suggestion, that if
, could be combined with if (mNtpAdapter == null)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we combined with if (mNtpAdapter == null)
then we have to change else
with else if(mNtpAdapter!=null)
so I think it's fine to keep as it is. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are right, my bad, let's keep as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Verification PASSED on
Verification PASSED on
|
Uplift of #16890 (squashed) to beta
Resolves brave/brave-browser#28089
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Got crash stack from GPS, so just make sure brave news is displaying