Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fix news ntp gps crash #16890

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Conversation

tapanmodh
Copy link
Contributor

Resolves brave/brave-browser#28089

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Got crash stack from GPS, so just make sure brave news is displaying

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 27, 2023
@tapanmodh tapanmodh added this to the 1.49.x - Nightly milestone Jan 27, 2023
@tapanmodh tapanmodh self-assigned this Jan 27, 2023
if (itemAnimator instanceof SimpleItemAnimator) {
SimpleItemAnimator simpleItemAnimator = (SimpleItemAnimator) itemAnimator;
simpleItemAnimator.setSupportsChangeAnimations(false);
if (mActivity != null && !mActivity.isDestroyed() && !mActivity.isFinishing()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor suggestion, that if, could be combined with if (mNtpAdapter == null)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we combined with if (mNtpAdapter == null) then we have to change else with else if(mNtpAdapter!=null) so I think it's fine to keep as it is. wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are right, my bad, let's keep as is.

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@tapanmodh tapanmodh merged commit 2882fe2 into master Jan 29, 2023
@tapanmodh tapanmodh deleted the fix_news_ntp_gps_crash_android branch January 29, 2023 04:51
brave-builds added a commit that referenced this pull request Jan 29, 2023
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 Pro running Android 8 via the Android Studio Emulator using the following build(s):

Brave | 1.49.77 Chromium: 110.0.5481.52 (Official Build) canary (32-bit) 
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 8.0.0; Build/OSR1.180418.026
  • ensured that you can opt-in/enable Brave News via the NTP without any issues
  • ensured that you can scroll through the news feed without any issues
  • ensured that you can tap/click on cards within the feed without any issues

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.77 Chromium: 110.0.5481.52 (Official Build) canary (32-bit)
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 13; Build/TQ1A.230105.002
  • ensured that you can opt-in/enable Brave News via the NTP without any issues
  • ensured that you can scroll through the news feed without any issues
  • ensured that you can tap/click on cards within the feed without any issues

kjozwiak pushed a commit that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on NTP
3 participants