Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short lived iframes browser test in SolanaProviderTest and EthereumProviderBrowserTest #16948

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Feb 1, 2023

Resolves brave/brave-browser#28179

This test is used to guard doing async call in native onload and callback will get null RenderFrame when the iframe no longer exists. If we forget to check nullity in the future, test will crash.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@darkdh darkdh requested a review from bbondy February 1, 2023 04:02
@darkdh darkdh requested a review from a team as a code owner February 1, 2023 04:02
@darkdh darkdh changed the title Add short lived iframes browser test Add short lived iframes browser test in SolanaProviderTest Feb 1, 2023
@darkdh darkdh force-pushed the solana-provider-short-lived-iframes branch from 92aaee7 to e911a61 Compare February 1, 2023 04:04
@darkdh darkdh force-pushed the solana-provider-short-lived-iframes branch from e911a61 to 8a7cb4f Compare February 1, 2023 18:12
@darkdh darkdh changed the title Add short lived iframes browser test in SolanaProviderTest Add short lived iframes browser test in SolanaProviderTest and EthereumProviderBrowserTest Feb 1, 2023
@darkdh darkdh force-pushed the solana-provider-short-lived-iframes branch from 8a7cb4f to 727b757 Compare February 1, 2023 18:17
@darkdh darkdh merged commit 4adf656 into master Feb 1, 2023
@darkdh darkdh deleted the solana-provider-short-lived-iframes branch February 1, 2023 20:35
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automated test to prevent Solana provider renderer crash
2 participants