Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fix crash enable brave news when no internet connection #17012

Merged
merged 1 commit into from
Feb 3, 2023
Merged

[Android] fix crash enable brave news when no internet connection #17012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion android/java/org/chromium/chrome/browser/ntp/BraveNtpAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,6 @@ public int getItemCount() {
int statsCount = getStatsCount();
int topSitesCount = getTopSitesCount();
int newsLoadingCount = shouldDisplayNewsLoading() ? 1 : 0;

if (mIsDisplayNewsOptin) {
return statsCount + topSitesCount + TWO_ITEMS_SPACE + newsLoadingCount;
} else if (mIsDisplayNews) {
Expand Down Expand Up @@ -468,6 +467,11 @@ public int getTopMarginImageCredit() {

public void setNewsLoading(boolean isNewsLoading) {
mIsNewsLoading = isNewsLoading;
if (isNewsLoading) {
notifyItemInserted(getStatsCount() + getTopSitesCount() + ONE_ITEM_SPACE);
} else {
notifyItemRemoved(getStatsCount() + getTopSitesCount() + ONE_ITEM_SPACE);
}
notifyItemRangeChanged(getStatsCount() + getTopSitesCount(), TWO_ITEMS_SPACE);
}

Expand Down