Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Release instead of Static in Android PRs #17462

Merged

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Mar 3, 2023

Resolves https://github.com/brave/devops/issues/9242

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 3, 2023
@wknapik wknapik self-assigned this Mar 3, 2023
@wknapik wknapik force-pushed the wknapik-build-release-in-android-prs-instead-of-static branch from 88f1131 to 03726c7 Compare March 3, 2023 12:48
@wknapik wknapik force-pushed the wknapik-build-release-in-android-prs-instead-of-static branch from 03726c7 to 33e4151 Compare March 7, 2023 11:07
@wknapik wknapik marked this pull request as ready for review March 7, 2023 11:07
@wknapik wknapik requested a review from a team as a code owner March 7, 2023 11:07
Jenkinsfile Show resolved Hide resolved
@wknapik wknapik merged commit d334e96 into master Mar 7, 2023
@wknapik wknapik deleted the wknapik-build-release-in-android-prs-instead-of-static branch March 7, 2023 13:11
@github-actions github-actions bot added this to the 1.51.x - Nightly milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants