-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check focus for location bar view #17573
Conversation
e3ebba4
to
002f4a8
Compare
002f4a8
to
b0617e9
Compare
Verified with
As per the issue brave/brave-browser#28694 I encountered this sometimes when using 1.49.x but did not find specific steps to reproduce. As such, I've generally tried the below to verify this PR, but since there aren't STR, I can't guarantee it's resolved 100%. Spot check of "Copy clean link" functionality - PASSED
General scenarios - PASSEDTried the below to reproduce the issue. Note, I encountered the copy problem while doing some of the below, but it didn't reproduce reliably.
|
Uplift of #17573 (squashed) to beta
Resolves brave/brave-browser#28694
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: