Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check focus for location bar view #17573

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Check focus for location bar view #17573

merged 1 commit into from
Mar 13, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 12, 2023

Resolves brave/brave-browser#28694

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • steps from issue

@spylogsster spylogsster self-assigned this Mar 12, 2023
@spylogsster spylogsster marked this pull request as ready for review March 13, 2023 09:03
@LaurenWags
Copy link
Member

LaurenWags commented Mar 16, 2023

Verified with

Brave | 1.51.37 Chromium: 111.0.5563.64 (Official Build) nightly (x86_64)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | macOS Version 12.6.3 (Build 21G419)

As per the issue brave/brave-browser#28694 I encountered this sometimes when using 1.49.x but did not find specific steps to reproduce. As such, I've generally tried the below to verify this PR, but since there aren't STR, I can't guarantee it's resolved 100%.

Spot check of "Copy clean link" functionality - PASSED
  1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
  2. Clicked the URL bar and confirmed "Copy clean link" available from macOS app menu
  3. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
  4. Confirmed "Copy clean link" is displayed in the share menu from URL bar
  5. Used "Cmd + C" while the URL bar is in focus to copy the URL
  6. Opened a new tab and pasted the copied URL
  7. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature brave-browser#23315
  8. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
  9. Selected "Copy clean link" from share menu in URL bar
  10. Opened a new tab and pasted the copied link
  11. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature brave-browser#23315
Step 2 Step 3 Step 4 Step 7 Step 8 Step 9 Step 11
2 3 4 7 8 9 11
General scenarios - PASSED

Tried the below to reproduce the issue. Note, I encountered the copy problem while doing some of the below, but it didn't reproduce reliably.

  1. Copying text from one GH issue description to another (same window, different tab)
  2. Copying text from one GH issue description to another (different windows)
  3. Restoring a GH issue from my macOS dock, copying text on GH issue, and then pasting it into a different GH issue in another window (not minimized)
  4. Switching between Brave and Slack, copying text from Brave to Slack

kjozwiak pushed a commit that referenced this pull request Mar 20, 2023
kjozwiak pushed a commit that referenced this pull request Mar 20, 2023
@spylogsster spylogsster deleted the brave-28694 branch May 16, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sometimes cmd+C doesn't copy expected text
3 participants