Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy keyboard shortcut is not assigned to 'copy clean link' in contex…(uplift #17487) #17610

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Copy keyboard shortcut is not assigned to 'copy clean link' in contex…(uplift #17487) #17610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser/ui/views/omnibox/brave_omnibox_view_views.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ bool BraveOmniboxViewViews::AcceleratorPressed(
CopySanitizedURL(url_to_copy.value());
return true;
}
#endif // BUILDFLAG(IS_WIN)

bool BraveOmniboxViewViews::GetAcceleratorForCommandId(
int command_id,
Expand All @@ -96,7 +97,6 @@ bool BraveOmniboxViewViews::GetAcceleratorForCommandId(
}
return OmniboxViewViews::GetAcceleratorForCommandId(command_id, accelerator);
}
#endif // BUILDFLAG(IS_WIN)

#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_MAC)
void BraveOmniboxViewViews::ExecuteTextEditCommand(
Expand Down
3 changes: 2 additions & 1 deletion browser/ui/views/omnibox/brave_omnibox_view_views.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ class BraveOmniboxViewViews : public OmniboxViewViews {
#if BUILDFLAG(IS_WIN)
// View overrides:
bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
#endif // BUILDFLAG(IS_WIN)
bool GetAcceleratorForCommandId(int command_id,
ui::Accelerator* accelerator) const override;
#endif // BUILDFLAG(IS_WIN)

#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_MAC)
// ui::views::Textfield
void ExecuteTextEditCommand(ui::TextEditCommand command) override;
Expand Down