Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: network selection during hardware import #18152

Merged
merged 1 commit into from
Apr 20, 2023
Merged

feat: network selection during hardware import #18152

merged 1 commit into from
Apr 20, 2023

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Apr 19, 2023 •
edited
Loading

Resolves brave/brave-browser#29662

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Create a Brave wallet
  2. Navigate to the accounts page and click "import from hardware wallet"
  3. select Ethereum/EVM, Solana, or Filecoin option
  4. connect the hardware device and view the list of accounts
  5. Use the new network filter to select another chain
  6. account balances update to the value of the account's balance on the newly selected chain

Repeat for all import types EVM, Solana and Filecoin.

Screenshot 2023-04-19 at 3 11 39 PM

@josheleonard josheleonard requested a review from a team as a code owner April 19, 2023 20:24
@josheleonard josheleonard self-assigned this Apr 19, 2023
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Apr 19, 2023
@josheleonard josheleonard force-pushed the feat-network-balance-selection-during-hardware-import branch 2 times, most recently from 0ef28d2 to 84e89b9 Compare April 19, 2023 20:33
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Douglashdaniel
Douglashdaniel approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@josheleonard josheleonard force-pushed the feat-network-balance-selection-during-hardware-import branch from 84e89b9 to 4ee8d8a Compare April 20, 2023 11:20
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the feat-network-balance-selection-during-hardware-import branch from 4ee8d8a to fb14f85 Compare April 20, 2023 11:41
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard merged commit bf8db7d into master Apr 20, 2023
@josheleonard josheleonard deleted the feat-network-balance-selection-during-hardware-import branch April 20, 2023 19:15
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 20, 2023
@srirambv srirambv mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Douglashdaniel Douglashdaniel Douglashdaniel approved these changes

@supermassive supermassive Awaiting requested review from supermassive

Assignees

@josheleonard josheleonard

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging this pull request may close these issues.

Allow checking hardware wallet balance across all networks during import
3 participants
@josheleonard @brave-builds @Douglashdaniel