Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash where target view is not in browser root view's hierarchy #18201

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

sangwoo108
Copy link
Contributor

Not only tab strip, but also other views in a widget for vertical tab strip, can be a drag target. In this case, we shouldn't count on ConvertPointToTarget()

Resolves brave/brave-browser#29929

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • enable vertical tab view
  • drag a bookmark from the bookmarks bar to tab strip
    • It'd be easier to reproduce to drag the bookmark through the top edge of vertical tab strip

Not only tab strip, but also other views in a widget for vertical
tab strip, can be a drag target. In this case, we shouldn't
count on ConvertPointToTarget()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave crashed when a bookmark was drag/opened from the bookmark bar in vertical tab view
3 participants