Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL comparison for landed ad, easter egg and search engine state #1914

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Fix URL comparison for landed ad, easter egg and search engine state #1914

merged 1 commit into from
Mar 12, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 12, 2019 •
edited
Loading

fixes brave/brave-browser#3680

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Test Landed Ads, Easter Egg and Search Engine state. Search engine state can be seen in Defaults/ads_service/client.json

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@tmancey tmancey added this to the 0.64.x - Nightly milestone Mar 12, 2019
@tmancey tmancey self-assigned this Mar 12, 2019
@tmancey tmancey force-pushed the issues/3680 branch 2 times, most recently from ef2ba5e to 49affe5 Compare March 12, 2019 03:25
@tmancey tmancey requested review from emerick and bridiver March 12, 2019 03:25
@tmancey tmancey changed the title Fix URL comparison for easter egg and search engines Fix URL comparison for landed ad, easter egg and search engines Mar 12, 2019
@tmancey tmancey marked this pull request as ready for review March 12, 2019 03:40
emerick
emerick previously approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

vendor/bat-native-ads/src/bat/ads/internal/ads_impl.cc Outdated Show resolved Hide resolved
@tmancey tmancey force-pushed the issues/3680 branch 3 times, most recently from 10839a4 to d3b309a Compare March 12, 2019 12:12
@tmancey tmancey requested a review from emerick March 12, 2019 12:13
emerick
emerick previously approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey requested a review from emerick March 12, 2019 12:57
emerick
emerick approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit e64d32f into master Mar 12, 2019
@tmancey tmancey deleted the issues/3680 branch March 12, 2019 13:01
@tmancey tmancey mentioned this pull request Mar 12, 2019
Merged
@tmancey tmancey changed the title Fix URL comparison for landed ad, easter egg and search engines Fix URL comparison for landed ad, easter egg and search engine state Mar 12, 2019
@MarkBuffalo MarkBuffalo mentioned this pull request Apr 19, 2024
Open
@kingjay66 kingjay66 mentioned this pull request Apr 19, 2024
Open
@CxsLucyfer CxsLucyfer mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
0.64.x - Release
Development

Successfully merging this pull request may close these issues.

Migration to Core has broken URL comparison for landed ad, easter egg and search engine state
3 participants
@tmancey @emerick @NejcZdovc