-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Linux app details to remove Google mention #1986
Conversation
There's a 3rd file at |
ae238e0
to
1fb6de4
Compare
<id>@@PACKAGE@@.desktop</id> | ||
- <update_contact>chromium-dev@chromium.org</update_contact> | ||
+ <update_contact>support@brave.com</update_contact> | ||
<metadata_license>CC0-1.0</metadata_license> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: this metadata_license
is for the actual XML file itself (not the project). More info available at https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html
Tested on my local machine and manpage patch works as expected. |
@simonhong good call- will update to do that 😄 |
1fb6de4
to
6d59be6
Compare
6d59be6
to
726633b
Compare
@simonhong @iefremov updated 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified this looks great by downloading the binaries provided by PR builder (https://s3-us-west-2.amazonaws.com/brave-jenkins-build-artifacts/brave-browser-build-pr/update-linux-app-details/3/brave-browser-dev_0.64.4_amd64.deb) BeforeAfter |
(NOTE: I haven't built/tested on Linux yet; will grab binaries from PR builder)
Please take a look at the files edited. Do these edits look correct? I want to make sure we update our Brand details (and also have relevant links for product issues / support), but I don't want to break any licensing terms
Fixes brave/brave-browser#392
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
See brave/brave-browser#392
Reviewer Checklist: