Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an explicitcancel ad-block filter option #2011

Closed
wants to merge 1 commit into from
Closed

Add an explicitcancel ad-block filter option #2011

wants to merge 1 commit into from

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Mar 19, 2019

@bbondy
Merge pull request #1981 from brave/force-block-option
447ed0c 
Add an explicitcancel ad-block filter option
@bbondy bbondy self-assigned this Mar 19, 2019
@bbondy bbondy requested a review from a team March 19, 2019 19:08
@bbondy bbondy added this to the 0.62.x - Beta milestone Mar 19, 2019
kjozwiak
kjozwiak approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.62.x approved after deliberating with @srirambv. Please ensure that all the correct labels are being used and all associated issues are moved into the correct milestone.

@bbondy
Copy link
Member Author

bbondy commented Mar 31, 2019

I'm going to NOT uplift this after all since we're too close to release and it's still not landed. We'll get it on 0.63.x.

@bbondy bbondy closed this Mar 31, 2019
@bbondy bbondy removed this from the 0.62.x - Release milestone Mar 31, 2019
@bsclifton bsclifton deleted the social-block-option-0.62.x branch April 13, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @kjozwiak