Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate Ephemeral Storage origin key on page reload. #20202

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Sep 18, 2023

Cleanup cached Ephemeral Storage origin in renderer to switch between ephemeral and normal storages on reload without issues.

Resolves brave/brave-browser#33077

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

ContentSettingsAgentImpl::DidCommitProvisionalLoad(transition);
// Invalidate Ephemeral Storage opaque origins. Page reload might change the
// Ephemeral Storage mode, in this case we should re-request it.
cached_ephemeral_storage_origins_.clear();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goodov goodov merged commit cd24de4 into master Sep 25, 2023
9 checks passed
@goodov goodov deleted the issues/33077 branch September 25, 2023 16:57
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ephemeral Storage on 1p is not working correctly with LocalStorage
2 participants