Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing IDS entries during the rebase 74.0.3729.28 #2044

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 23, 2019

Recent rebase has new IDS entries but we missed it.
updated by npm run chromium_rebase_l10n

Fix brave/brave-browser#3865

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong simonhong added this to the 0.64.x - Nightly milestone Mar 23, 2019
@simonhong simonhong self-assigned this Mar 23, 2019
@bsclifton bsclifton merged commit 905d672 into master Mar 23, 2019
@bsclifton bsclifton deleted the update_grd_of_v_74_28 branch March 23, 2019 16:32
bsclifton added a commit that referenced this pull request Mar 23, 2019
This reverts commit 905d672, reversing
changes made to f822a3a.
@bsclifton bsclifton mentioned this pull request Mar 23, 2019
19 tasks
bsclifton added a commit that referenced this pull request Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing IDS entries after rebasing to 74.0.3729.28
3 participants