Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable metrics services on 0.63.x #2074

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Disable metrics services on 0.63.x #2074

merged 2 commits into from
Mar 26, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Mar 26, 2019 •
edited
Loading

Original PR: #2029

Reason for uplift: Required to disable metrics services enabled by fix for #1985

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jumde
Merge pull request #2029 from brave/fix_3816
cff249c 
Disabling metrics reporting; Updating ad-block deps to fix audit_deps error; Updating crypto deps to fix audit_deps error;
@jumde jumde changed the title https://github.com/brave/brave-core/pull/2029 Fix test-security on 0.63.x Mar 26, 2019
@jumde jumde requested a review from a team March 26, 2019 02:18
@jumde jumde self-assigned this Mar 26, 2019
@jumde jumde changed the title Fix test-security on 0.63.x Disable metrics services on 0.63.x Mar 26, 2019
@jumde jumde merged commit acca7ca into 0.63.x Mar 26, 2019
@jumde jumde deleted the fix_3816_0.63.x branch March 26, 2019 16:22
jumde added a commit that referenced this pull request Mar 27, 2019
@jumde
Revert "Merge pull request #2074 from brave/fix_3816_0.63.x"
57c3a23 
This reverts commit acca7ca, reversing
changes made to 7ff136e.
@bbondy bbondy added this to the 0.63.x - Beta milestone Mar 31, 2019
@gdregalo
Copy link
Contributor

The above commit is related to android browser (not to brave-core). Sorry for confusion.

fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #2074 from brave/release-notes-0.56.x
046128a 
Release notes for 0.56.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
0.63.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@jumde @gdregalo @bbondy