Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: display error when transaction fee estimate fails (Uplift to 1.61.x) #21626

Closed
wants to merge 2 commits into from
Closed

Fix: display error when transaction fee estimate fails (Uplift to 1.61.x) #21626

wants to merge 2 commits into from

Conversation

josheleonard
Copy link
Contributor

Uplift of #21624, #21188

Resolves brave/brave-browser#35413
Resolves brave/brave-browser#34661

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@josheleonard
chore: consolidate tx confirmation panels
a1ac357 
* chore: consolidate tx confirmation panels

* chore: combine transaction-info components

* chore: combine transaction-detail components

* fix: allow rows to wrap content

* fix: allow tx confirm to-from row to wrap

* chore: remove max-width prop from column component
@josheleonard
fix: display error when transaction fees can not be estimated
043df31
@josheleonard josheleonard requested a review from a team as a code owner January 18, 2024 17:44
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Jan 18, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak reviewed Jan 19, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to close this one off as we're not going to have another 1.61.x unless there's a zero day release on Friday/Monday. The following fix will be uplifted/released via 1.62.x which is going out next week.

@kjozwiak kjozwiak closed this Jan 19, 2024
@kjozwiak kjozwiak deleted the chore--consolidate-tx-confirmation-panels-1.61.x branch January 19, 2024 06:29
@kjozwiak kjozwiak removed CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees

@josheleonard josheleonard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josheleonard @brave-builds @kjozwiak