Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Buy Deposit Bridge Button Styles #22212

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Douglashdaniel
Copy link
Contributor

Description

Updates all of the Buy, Deposit, Bridge button styles to match the new designs in figma

Resolves brave/brave-browser#36265

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Before:

Screenshot 18

Screenshot 19

After:

Screenshot 21

Screenshot 20

@Douglashdaniel Douglashdaniel self-assigned this Feb 21, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 21, 2024 15:33
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Feb 21, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 6f06d4f into master Feb 21, 2024
19 of 20 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-buy-deposit-bridge-button-styles branch February 21, 2024 19:04
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Buy Deposit Bridge Button Styles
3 participants