Extension observer comparison code is now moved to front side #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
changed the title
emerick
reviewed
Apr 16, 2019
| case types.ON_WALLET_CORRUPTED: | ||
| state = { ...state } | ||
| state.walletCorrupted = true | ||
| if (result === 12) { // ledger::Result::WALLET_CREATED |
There was a problem hiding this comment.
Should these results be in some kind of enumeration?
There was a problem hiding this comment.
The problem I was seeing is that this result comes from an enum in Ledger. Currently we would have to keep track of making sure the Ledger enum and an enum here would stay in sync.
There was a problem hiding this comment.
we already do this and you have definition in rewards.d.ts -> Rewards.Result
There was a problem hiding this comment.
Nice! Never saw that
There was a problem hiding this comment.
Sadly, per @NejcZdovc there is currently a problem using ts enum in reducer
There was a problem hiding this comment.
The enum declaration needs to be exported as const in order to work properly. Done.
jasonrsadler
force-pushed
the
wallet_init_refactor
branch
from
909a4ae
to
54e8e4e
Compare
emerick
previously approved these changes
Apr 16, 2019
NejcZdovc
reviewed
Apr 18, 2019
components/brave_rewards/resources/extension/brave_rewards/actions/rewards_panel_actions.ts
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Apr 18, 2019
components/brave_rewards/resources/extension/brave_rewards/background/events/rewardsEvents.ts
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Apr 18, 2019
NejcZdovc
previously approved these changes
Apr 18, 2019
jasonrsadler
force-pushed
the
wallet_init_refactor
branch
from
54e8e4e
to
e25358c
Compare
Updated enum declaration to const
jasonrsadler
force-pushed
the
wallet_init_refactor
branch
from
e25358c
to
32dd80d
Compare
jasonrsadler
requested review from
emerick and
NejcZdovc
and removed request for
emerick
NejcZdovc
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#3974
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: