Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads shows region not supported on upgrade 0.63.x #2273

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Ads shows region not supported on upgrade 0.63.x #2273

merged 2 commits into from
Apr 19, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 18, 2019 •
edited
Loading

Uplift for #2263
Fixes brave/brave-browser#4154
Requires #2277

@tmancey tmancey added this to the 0.63.x - Release milestone Apr 18, 2019
@tmancey tmancey requested a review from a team April 18, 2019 21:58
@tmancey tmancey self-assigned this Apr 18, 2019
@tmancey tmancey mentioned this pull request Apr 18, 2019
Merged
@ryanml @tmancey
Merge pull request #2232 from /issues/3967
79facd3 
Fix Ads enabled for unsupported regions and enabled by default after 0.63.x update
@ryanml @tmancey
Merge pull request #2263 from brave/fix-4154
7a2fbfc 
Fix Shows supported region correctly for Ads on first load after upgrade.
@tmancey tmancey marked this pull request as ready for review April 18, 2019 22:27
rebron
rebron approved these changes Apr 19, 2019
View reviewed changes
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tmancey
Copy link
Collaborator Author

tmancey commented Apr 19, 2019

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they're landing to.

@tmancey tmancey merged commit ff35222 into 0.63.x Apr 19, 2019
@tmancey tmancey deleted the issues/4154-0.63.x branch April 19, 2019 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebron rebron rebron approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads feature/rewards
Projects
None yet
Milestone
0.63.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@tmancey @rebron @ryanml