Issue 4328: Proxying requests for sb-ssl.google.com for file proxy checks through sb-ssl.brave.com #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
previously approved these changes
May 6, 2019
jumde
force-pushed
the
sbssl_proxy
branch
2 times, most recently
from
347a866 to
e24dba0
Compare
diracdeltas
reviewed
May 7, 2019
| brave::ResponseCallback callback; | ||
| GURL::Replacements replacements; | ||
| replacements.SetHostStr(kBraveSafeBrowsingFileCheckProxy); | ||
| GURL expected_url(url.ReplaceComponents(replacements)); |
There was a problem hiding this comment.
minor: i think this test would be more precise if it tested for the literal expected string, like https://sb-ssl.brave.com/... instead of url.ReplaceComponents(replacements)
…ecks through sb-ssl.brave.com auditors: @riastradh-brave, @diracdeltas
diracdeltas
approved these changes
May 8, 2019
riastradh-brave
approved these changes
May 8, 2019
brave-builds
pushed a commit
that referenced
this pull request
May 8, 2019
brave-builds
pushed a commit
that referenced
this pull request
May 8, 2019
brave-builds
pushed a commit
that referenced
this pull request
May 8, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#4328
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
<DATA_DIR>/Safe Browsingtestsafebrowsing.appspot.com- Verify that the download checks work correctlysb-ssl.google.comusing a proxy (Fiddler for windows/linux and little snitch for mac-os)Reviewer Checklist:
After-merge Checklist:
changes has landed on.