-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable lookalike url feature #2382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yay! Builder is happy with this PR :) |
bbondy
approved these changes
May 8, 2019
Please do uplifts of this to 0.65.x after this lands on Nightly too. |
brave-builds
pushed a commit
that referenced
this pull request
May 8, 2019
brave-builds
pushed a commit
that referenced
this pull request
May 8, 2019
This was referenced May 8, 2019
brave-builds
pushed a commit
that referenced
this pull request
May 8, 2019
brave-builds
pushed a commit
that referenced
this pull request
May 8, 2019
This was referenced May 8, 2019
simonhong
pushed a commit
that referenced
this pull request
May 9, 2019
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
check src/brave/brave_sync/extension for npm vulnerabilities
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
check src/brave/brave_sync/extension for npm vulnerabilities
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
check src/brave/brave_sync/extension for npm vulnerabilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#4304
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
yarn test brave_browser_tests --filter=BraveMainDelegateBrowserTest.DisabledFeatures
Reviewer Checklist:
After-merge Checklist:
changes has landed on.